From 15a1f5bd55735f6f65a6fd9e2e86bb4a3f5ac815 Mon Sep 17 00:00:00 2001 From: Phil Sutter Date: Thu, 28 Sep 2017 17:17:44 +0200 Subject: rule: Refactor chain_print_declaration() Instead of having two nearly identical printf() calls for netdev and other chains, print the common parts separately and include the device bit only for netdev chains. Signed-off-by: Phil Sutter Signed-off-by: Pablo Neira Ayuso --- src/rule.c | 18 ++++++------------ 1 file changed, 6 insertions(+), 12 deletions(-) (limited to 'src') diff --git a/src/rule.c b/src/rule.c index b122f020..f88cfcbc 100644 --- a/src/rule.c +++ b/src/rule.c @@ -666,18 +666,12 @@ static void chain_print_declaration(const struct chain *chain) { printf("\tchain %s {\n", chain->handle.chain); if (chain->flags & CHAIN_F_BASECHAIN) { - if (chain->dev != NULL) { - printf("\t\ttype %s hook %s device %s priority %d; policy %s;\n", - chain->type, - hooknum2str(chain->handle.family, chain->hooknum), - chain->dev, chain->priority, - chain_policy2str(chain->policy)); - } else { - printf("\t\ttype %s hook %s priority %d; policy %s;\n", - chain->type, - hooknum2str(chain->handle.family, chain->hooknum), - chain->priority, chain_policy2str(chain->policy)); - } + printf("\t\ttype %s hook %s", chain->type, + hooknum2str(chain->handle.family, chain->hooknum)); + if (chain->dev != NULL) + printf(" device %s", chain->dev); + printf(" priority %d; policy %s;\n", + chain->priority, chain_policy2str(chain->policy)); } } -- cgit v1.2.3