From 6b7b7d5d219dca4465390f4a69096383d17782d3 Mon Sep 17 00:00:00 2001 From: Pablo Neira Ayuso Date: Thu, 1 Apr 2021 23:15:02 +0200 Subject: cache: check for NULL chain in cache_init() Another process might race to add chains after chain_cache_init(). The generation check does not help since it comes after cache_init(). NLM_F_DUMP_INTR only guarantees consistency within one single netlink dump operation, so it does not help either (cache population requires several netlink dump commands). Let's be safe and do not assume the chain exists in the cache when populating the rule cache. Signed-off-by: Pablo Neira Ayuso --- src/cache.c | 5 +++++ 1 file changed, 5 insertions(+) (limited to 'src') diff --git a/src/cache.c b/src/cache.c index f7187ee7..4e573676 100644 --- a/src/cache.c +++ b/src/cache.c @@ -338,6 +338,11 @@ static int cache_init_objects(struct netlink_ctx *ctx, unsigned int flags) if (!chain) chain = chain_binding_lookup(table, rule->handle.chain.name); + if (!chain) { + ret = -1; + goto cache_fails; + } + list_move_tail(&rule->list, &chain->rules); } if (ret < 0) { -- cgit v1.2.3