From fa409176af98a53304b8b448f20f4b5e5cc299fa Mon Sep 17 00:00:00 2001 From: Pablo Neira Ayuso Date: Fri, 17 Jun 2022 18:17:49 +0200 Subject: optimize: only merge OP_IMPLICIT and OP_EQ relational Add test to cover this case. Signed-off-by: Pablo Neira Ayuso --- src/optimize.c | 10 ++++++++++ 1 file changed, 10 insertions(+) (limited to 'src') diff --git a/src/optimize.c b/src/optimize.c index e3d4bc78..e4508fa5 100644 --- a/src/optimize.c +++ b/src/optimize.c @@ -164,6 +164,11 @@ static bool __stmt_type_eq(const struct stmt *stmt_a, const struct stmt *stmt_b, expr_a = stmt_a->expr; expr_b = stmt_b->expr; + if (expr_a->op != expr_b->op) + return false; + if (expr_a->op != OP_IMPLICIT && expr_a->op != OP_EQ) + return false; + if (fully_compare) { if (!stmt_expr_supported(expr_a) || !stmt_expr_supported(expr_b)) @@ -351,6 +356,11 @@ static int rule_collect_stmts(struct optimize_ctx *ctx, struct rule *rule) clone = stmt_alloc(&internal_location, stmt->ops); switch (stmt->ops->type) { case STMT_EXPRESSION: + if (stmt->expr->op != OP_IMPLICIT && + stmt->expr->op != OP_EQ) { + clone->ops = &unsupported_stmt_ops; + break; + } case STMT_VERDICT: clone->expr = expr_get(stmt->expr); break; -- cgit v1.2.3