From 788c986343bc24bd0272e8aa409121ffe51f1ef3 Mon Sep 17 00:00:00 2001 From: Pablo Neira Ayuso Date: Mon, 15 Aug 2016 13:14:18 +0200 Subject: src: quote user-defined strings when used from rule selectors The following selectors display strings using quotes: * meta iifname * meta oifname * meta ibriport * meta obriport However, the following do not: * meta oif * meta iif * meta skuid * meta skgid * meta iifgroup * meta oifgroup * meta rtclassid * ct label Given they refer to user-defined values, neither keywords nor internal built-in known values, let's quote the output of this. This patch modifies symbolic_constant_print() so we can signal this to indicate if the string needs to be quoted. Signed-off-by: Pablo Neira Ayuso --- tests/py/ip/ip.t | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) (limited to 'tests/py/ip/ip.t') diff --git a/tests/py/ip/ip.t b/tests/py/ip/ip.t index 8fa53be4..8ed2e99c 100644 --- a/tests/py/ip/ip.t +++ b/tests/py/ip/ip.t @@ -123,11 +123,11 @@ ip hdrlength 15;ok ip hdrlength 16;fail # limit impact to lo -iif lo ip daddr set 127.0.0.1;ok -iif lo ip checksum set 0;ok -iif lo ip id set 0;ok -iif lo ip ecn set 1;ok;iif lo ip ecn set ect1 -iif lo ip ecn set ce;ok - -iif lo ip dscp set af23;ok -iif lo ip dscp set cs0;ok +iif "lo" ip daddr set 127.0.0.1;ok +iif "lo" ip checksum set 0;ok +iif "lo" ip id set 0;ok +iif "lo" ip ecn set 1;ok;iif "lo" ip ecn set ect1 +iif "lo" ip ecn set ce;ok + +iif "lo" ip dscp set af23;ok +iif "lo" ip dscp set cs0;ok -- cgit v1.2.3