From b450c12223c4fc3fd8389809dace7dbccd513e95 Mon Sep 17 00:00:00 2001 From: Thomas Haller Date: Mon, 18 Sep 2023 21:59:24 +0200 Subject: tests/shell: run `nft --check` on persisted dump files "nft --check" will trigger a rollback in kernel. The existing dump files might hit new code paths. Take the opportunity to call the command on the existing files. And alternative would be to write a separate tests, that iterates over all files. However, then we can only run all the commands sequentially (unless we do something smart). That might be slower than the opportunity to run the checks in parallel. More importantly, it would be nice if the check for the dump file is clearly tied to the file's test. So run it right after the test, from the test wrapper. Signed-off-by: Thomas Haller Signed-off-by: Florian Westphal --- tests/shell/run-tests.sh | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) (limited to 'tests/shell/run-tests.sh') diff --git a/tests/shell/run-tests.sh b/tests/shell/run-tests.sh index 03021085..5ef6359f 100755 --- a/tests/shell/run-tests.sh +++ b/tests/shell/run-tests.sh @@ -740,7 +740,9 @@ print_test_result() { else ((failed++)) result_msg_level="W" - if [ "$rc_got" -eq 122 ] ; then + if [ "$rc_got" -eq 121 ] ; then + result_msg_status="CHK DUMP" + elif [ "$rc_got" -eq 122 ] ; then result_msg_status="VALGRIND" elif [ "$rc_got" -eq 123 ] ; then result_msg_status="TAINTED" -- cgit v1.2.3