From 751336b7bffea4065bcd9f895eef3159addaba3e Mon Sep 17 00:00:00 2001 From: Florian Westphal Date: Fri, 2 Apr 2021 12:54:53 +0200 Subject: proto: replace vlan ether type with 8021q Previous patches added "8021ad" mnemonic for IEEE 802.1AD frame type. This adds the 8021q shorthand for the existing 'vlan' frame type. nft will continue to recognize 'ether type vlan', but listing will now print 8021q. Adjust all test cases accordingly. Suggested-by: Pablo Neira Ayuso Signed-off-by: Florian Westphal --- tests/py/any/meta.t | 4 ++-- tests/py/any/meta.t.json | 4 ++-- tests/py/any/meta.t.json.output | 6 +++--- tests/py/any/meta.t.payload | 2 +- tests/py/bridge/meta.t | 2 +- tests/py/bridge/meta.t.json | 2 +- tests/py/bridge/reject.t | 6 +++--- tests/py/bridge/reject.t.json | 6 +++--- tests/py/bridge/reject.t.json.output | 3 +-- tests/py/bridge/reject.t.payload | 2 +- tests/py/bridge/vlan.t | 6 +++--- tests/py/bridge/vlan.t.json | 8 ++++---- tests/py/bridge/vlan.t.json.output | 10 +++++----- tests/py/bridge/vlan.t.payload | 4 ++-- tests/py/bridge/vlan.t.payload.netdev | 4 ++-- 15 files changed, 34 insertions(+), 35 deletions(-) (limited to 'tests') diff --git a/tests/py/any/meta.t b/tests/py/any/meta.t index 7b582505..0b894cce 100644 --- a/tests/py/any/meta.t +++ b/tests/py/any/meta.t @@ -20,8 +20,8 @@ meta length != { 33, 55, 67, 88};ok meta length { 33-55, 66-88};ok meta length != { 33-55, 66-88};ok -meta protocol { ip, arp, ip6, vlan };ok;meta protocol { ip6, ip, vlan, arp} -meta protocol != {ip, arp, ip6, vlan};ok +meta protocol { ip, arp, ip6, vlan };ok;meta protocol { ip6, ip, 8021q, arp} +meta protocol != {ip, arp, ip6, 8021q};ok meta protocol ip;ok meta protocol != ip;ok diff --git a/tests/py/any/meta.t.json b/tests/py/any/meta.t.json index 47dc0724..1a98843c 100644 --- a/tests/py/any/meta.t.json +++ b/tests/py/any/meta.t.json @@ -199,7 +199,7 @@ } ] -# meta protocol != {ip, arp, ip6, vlan} +# meta protocol != {ip, arp, ip6, 8021q} [ { "match": { @@ -212,7 +212,7 @@ "ip", "arp", "ip6", - "vlan" + "8021q" ] } } diff --git a/tests/py/any/meta.t.json.output b/tests/py/any/meta.t.json.output index 74b934b8..4e9e669f 100644 --- a/tests/py/any/meta.t.json.output +++ b/tests/py/any/meta.t.json.output @@ -10,7 +10,7 @@ "set": [ "ip", "arp", - "vlan", + "8021q", "ip6" ] } @@ -18,7 +18,7 @@ } ] -# meta protocol != {ip, arp, ip6, vlan} +# meta protocol != {ip, arp, ip6, 8021q} [ { "match": { @@ -30,7 +30,7 @@ "set": [ "ip", "arp", - "vlan", + "8021q", "ip6" ] } diff --git a/tests/py/any/meta.t.payload b/tests/py/any/meta.t.payload index 99aab29c..4e43905e 100644 --- a/tests/py/any/meta.t.payload +++ b/tests/py/any/meta.t.payload @@ -68,7 +68,7 @@ ip test-ip4 input [ meta load protocol => reg 1 ] [ lookup reg 1 set __set%d ] -# meta protocol != {ip, arp, ip6, vlan} +# meta protocol != {ip, arp, ip6, 8021q} __set%d test-ip4 3 __set%d test-ip4 0 element 00000008 : 0 [end] element 00000608 : 0 [end] element 0000dd86 : 0 [end] element 00000081 : 0 [end] diff --git a/tests/py/bridge/meta.t b/tests/py/bridge/meta.t index 94525f29..eda7082f 100644 --- a/tests/py/bridge/meta.t +++ b/tests/py/bridge/meta.t @@ -4,5 +4,5 @@ meta obrname "br0";ok meta ibrname "br0";ok -meta ibrvproto vlan;ok +meta ibrvproto vlan;ok;meta ibrvproto 8021q meta ibrpvid 100;ok diff --git a/tests/py/bridge/meta.t.json b/tests/py/bridge/meta.t.json index a7a180c2..3122774e 100644 --- a/tests/py/bridge/meta.t.json +++ b/tests/py/bridge/meta.t.json @@ -32,7 +32,7 @@ "meta": { "key": "ibrvproto" } }, "op": "==", - "right": "vlan" + "right": "8021q" } } ] diff --git a/tests/py/bridge/reject.t b/tests/py/bridge/reject.t index ee33af77..b242eef4 100644 --- a/tests/py/bridge/reject.t +++ b/tests/py/bridge/reject.t @@ -30,13 +30,13 @@ reject with icmpx type port-unreachable;ok;reject ether type ipv6 reject with icmp type host-unreachable;fail ether type ip6 reject with icmp type host-unreachable;fail ether type ip reject with icmpv6 type no-route;fail -ether type vlan reject;ok +ether type vlan reject;ok;ether type 8021q reject ether type arp reject;fail -ether type vlan reject with tcp reset;ok;meta l4proto 6 ether type vlan reject with tcp reset +ether type vlan reject with tcp reset;ok;meta l4proto 6 ether type 8021q reject with tcp reset ether type arp reject with tcp reset;fail ip protocol udp reject with tcp reset;fail ether type ip reject with icmpx type admin-prohibited;ok ether type ip6 reject with icmpx type admin-prohibited;ok -ether type vlan reject with icmpx type admin-prohibited;ok +ether type 8021q reject with icmpx type admin-prohibited;ok ether type arp reject with icmpx type admin-prohibited;fail diff --git a/tests/py/bridge/reject.t.json b/tests/py/bridge/reject.t.json index aea871f7..fe21734d 100644 --- a/tests/py/bridge/reject.t.json +++ b/tests/py/bridge/reject.t.json @@ -289,7 +289,7 @@ } }, "op": "==", - "right": "vlan" + "right": "8021q" } }, { @@ -318,7 +318,7 @@ } ] -# ether type vlan reject with icmpx type admin-prohibited +# ether type 8021q reject with icmpx type admin-prohibited [ { "match": { @@ -329,7 +329,7 @@ } }, "op": "==", - "right": "vlan" + "right": "8021q" } }, { diff --git a/tests/py/bridge/reject.t.json.output b/tests/py/bridge/reject.t.json.output index e01a63af..b8a44f0e 100644 --- a/tests/py/bridge/reject.t.json.output +++ b/tests/py/bridge/reject.t.json.output @@ -71,7 +71,7 @@ } }, "op": "==", - "right": "vlan" + "right": "8021q" } }, { @@ -81,4 +81,3 @@ } } ] - diff --git a/tests/py/bridge/reject.t.payload b/tests/py/bridge/reject.t.payload index 7deb6fbf..22569877 100644 --- a/tests/py/bridge/reject.t.payload +++ b/tests/py/bridge/reject.t.payload @@ -132,7 +132,7 @@ bridge [ cmp eq reg 1 0x00000081 ] [ reject type 1 code 0 ] -# ether type vlan reject with icmpx type admin-prohibited +# ether type 8021q reject with icmpx type admin-prohibited bridge [ payload load 2b @ link header + 12 => reg 1 ] [ cmp eq reg 1 0x00000081 ] diff --git a/tests/py/bridge/vlan.t b/tests/py/bridge/vlan.t index 8553ba56..f67b8180 100644 --- a/tests/py/bridge/vlan.t +++ b/tests/py/bridge/vlan.t @@ -32,12 +32,12 @@ ether type vlan vlan id 1 ip saddr 10.0.0.0/23 udp dport 53;ok;vlan id 1 ip sadd vlan id { 1, 2, 4, 100, 4095 } vlan pcp 1-3;ok vlan id { 1, 2, 4, 100, 4096 };fail -ether type vlan ip protocol 1 accept;ok +ether type vlan ip protocol 1 accept;ok;ether type 8021q ip protocol 1 accept # IEEE 802.1AD ether type 8021ad vlan id 1 ip protocol 6 accept;ok -ether type 8021ad vlan id 1 vlan type vlan vlan id 2 vlan type ip counter;ok -ether type 8021ad vlan id 1 vlan type vlan vlan id 2 vlan type ip ip protocol 6;ok;ether type 8021ad vlan id 1 vlan type vlan vlan id 2 ip protocol 6 +ether type 8021ad vlan id 1 vlan type 8021q vlan id 2 vlan type ip counter;ok +ether type 8021ad vlan id 1 vlan type 8021q vlan id 2 vlan type ip ip protocol 6;ok;ether type 8021ad vlan id 1 vlan type 8021q vlan id 2 ip protocol 6 # illegal dependencies ether type ip vlan id 1;fail diff --git a/tests/py/bridge/vlan.t.json b/tests/py/bridge/vlan.t.json index 8eab271d..2a4b64f2 100644 --- a/tests/py/bridge/vlan.t.json +++ b/tests/py/bridge/vlan.t.json @@ -573,7 +573,7 @@ } ] -# ether type 8021ad vlan id 1 vlan type vlan vlan id 2 vlan type ip counter +# ether type 8021ad vlan id 1 vlan type 8021q vlan id 2 vlan type ip counter [ { "match": { @@ -608,7 +608,7 @@ } }, "op": "==", - "right": "vlan" + "right": "8021q" } }, { @@ -643,7 +643,7 @@ } ] -# ether type 8021ad vlan id 1 vlan type vlan vlan id 2 vlan type ip ip protocol 6 +# ether type 8021ad vlan id 1 vlan type 8021q vlan id 2 vlan type ip ip protocol 6 [ { "match": { @@ -678,7 +678,7 @@ } }, "op": "==", - "right": "vlan" + "right": "8021q" } }, { diff --git a/tests/py/bridge/vlan.t.json.output b/tests/py/bridge/vlan.t.json.output index a2cc212e..2f90c8ff 100644 --- a/tests/py/bridge/vlan.t.json.output +++ b/tests/py/bridge/vlan.t.json.output @@ -9,7 +9,7 @@ } }, "op": "==", - "right": "vlan" + "right": "8021q" } }, { @@ -72,7 +72,7 @@ } ] -# ether type 8021ad vlan id 1 vlan type vlan vlan id 2 vlan type ip counter +# ether type 8021ad vlan id 1 vlan type 8021q vlan id 2 vlan type ip counter [ { "match": { @@ -107,7 +107,7 @@ } }, "op": "==", - "right": "vlan" + "right": "8021q" } }, { @@ -139,7 +139,7 @@ } ] -# ether type 8021ad vlan id 1 vlan type vlan vlan id 2 vlan type ip ip protocol 6 +# ether type 8021ad vlan id 1 vlan type 8021q vlan id 2 vlan type ip ip protocol 6 [ { "match": { @@ -174,7 +174,7 @@ } }, "op": "==", - "right": "vlan" + "right": "8021q" } }, { diff --git a/tests/py/bridge/vlan.t.payload b/tests/py/bridge/vlan.t.payload index f60c752d..a78f2946 100644 --- a/tests/py/bridge/vlan.t.payload +++ b/tests/py/bridge/vlan.t.payload @@ -222,7 +222,7 @@ bridge [ cmp eq reg 1 0x00000006 ] [ immediate reg 0 accept ] -# ether type 8021ad vlan id 1 vlan type vlan vlan id 2 vlan type ip counter +# ether type 8021ad vlan id 1 vlan type 8021q vlan id 2 vlan type ip counter bridge [ payload load 2b @ link header + 12 => reg 1 ] [ cmp eq reg 1 0x0000a888 ] @@ -238,7 +238,7 @@ bridge [ cmp eq reg 1 0x00000008 ] [ counter pkts 0 bytes 0 ] -# ether type 8021ad vlan id 1 vlan type vlan vlan id 2 vlan type ip ip protocol 6 +# ether type 8021ad vlan id 1 vlan type 8021q vlan id 2 vlan type ip ip protocol 6 bridge [ payload load 2b @ link header + 12 => reg 1 ] [ cmp eq reg 1 0x0000a888 ] diff --git a/tests/py/bridge/vlan.t.payload.netdev b/tests/py/bridge/vlan.t.payload.netdev index 94ca6867..22e244e2 100644 --- a/tests/py/bridge/vlan.t.payload.netdev +++ b/tests/py/bridge/vlan.t.payload.netdev @@ -260,7 +260,7 @@ netdev [ cmp eq reg 1 0x00000006 ] [ immediate reg 0 accept ] -# ether type 8021ad vlan id 1 vlan type vlan vlan id 2 vlan type ip counter +# ether type 8021ad vlan id 1 vlan type 8021q vlan id 2 vlan type ip counter netdev [ meta load iiftype => reg 1 ] [ cmp eq reg 1 0x00000001 ] @@ -278,7 +278,7 @@ netdev [ cmp eq reg 1 0x00000008 ] [ counter pkts 0 bytes 0 ] -# ether type 8021ad vlan id 1 vlan type vlan vlan id 2 vlan type ip ip protocol 6 +# ether type 8021ad vlan id 1 vlan type 8021q vlan id 2 vlan type ip ip protocol 6 netdev [ meta load iiftype => reg 1 ] [ cmp eq reg 1 0x00000001 ] -- cgit v1.2.3