diff options
| author | Jeremy Sowden <jeremy@azazel.net> | 2021-11-30 10:55:58 +0000 |
|---|---|---|
| committer | Pablo Neira Ayuso <pablo@netfilter.org> | 2022-01-03 17:58:23 +0100 |
| commit | a5d2789474494fae044a48fbffe84601f3f40374 (patch) | |
| tree | 42a272790a2861e99b1e70b7873f812f80e24feb /output/ulogd_output_JSON.c | |
| parent | bba33e0219b9a12aaf2bdd96315bd5c95026fa84 (diff) | |
output: JSON: optimize appending of newline to output
We have `buflen` available. We can remove `strncat` and assign the characters
directly, without traversing the whole buffer.
Fixes a compiler warning:
logd_output_JSON.c:407:9: warning: `strncat` specified bound 1 equals source length
Signed-off-by: Jeremy Sowden <jeremy@azazel.net>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
Diffstat (limited to 'output/ulogd_output_JSON.c')
| -rw-r--r-- | output/ulogd_output_JSON.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/output/ulogd_output_JSON.c b/output/ulogd_output_JSON.c index 2166d15..913dfb8 100644 --- a/output/ulogd_output_JSON.c +++ b/output/ulogd_output_JSON.c @@ -404,8 +404,8 @@ static int json_interp(struct ulogd_pluginstance *upi) return ULOGD_IRET_ERR; } buf = tmp; - strncat(buf, "\n", 1); - buflen++; + buf[buflen++] = '\n'; + buf[buflen] = '\0'; if (opi->mode == JSON_MODE_FILE) return json_interp_file(upi, buf); |