From a5d2789474494fae044a48fbffe84601f3f40374 Mon Sep 17 00:00:00 2001 From: Jeremy Sowden Date: Tue, 30 Nov 2021 10:55:58 +0000 Subject: output: JSON: optimize appending of newline to output We have `buflen` available. We can remove `strncat` and assign the characters directly, without traversing the whole buffer. Fixes a compiler warning: logd_output_JSON.c:407:9: warning: `strncat` specified bound 1 equals source length Signed-off-by: Jeremy Sowden Signed-off-by: Pablo Neira Ayuso --- output/ulogd_output_JSON.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'output/ulogd_output_JSON.c') diff --git a/output/ulogd_output_JSON.c b/output/ulogd_output_JSON.c index 2166d15..913dfb8 100644 --- a/output/ulogd_output_JSON.c +++ b/output/ulogd_output_JSON.c @@ -404,8 +404,8 @@ static int json_interp(struct ulogd_pluginstance *upi) return ULOGD_IRET_ERR; } buf = tmp; - strncat(buf, "\n", 1); - buflen++; + buf[buflen++] = '\n'; + buf[buflen] = '\0'; if (opi->mode == JSON_MODE_FILE) return json_interp_file(upi, buf); -- cgit v1.2.3