diff options
| author | Bart De Schuymer <bdschuym@pandora.be> | 2004-03-25 18:06:28 +0000 |
|---|---|---|
| committer | Bart De Schuymer <bdschuym@pandora.be> | 2004-03-25 18:06:28 +0000 |
| commit | cdf7ed0a3608c3f2f903c3d7373ac7ec2b4d9959 (patch) | |
| tree | 6ecbc7724539971526e8bc6edc547138f5f9e988 /extensions | |
| parent | 5c1bb39ba33215e0e1ed6ebb4d7449960c6b0dbe (diff) | |
Rémi Denis-Courmont: fix segfault with malformed MAC address
Diffstat (limited to 'extensions')
| -rw-r--r-- | extensions/arpt_mangle.c | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/extensions/arpt_mangle.c b/extensions/arpt_mangle.c index fa59b13..3bf44e4 100644 --- a/extensions/arpt_mangle.c +++ b/extensions/arpt_mangle.c @@ -105,6 +105,8 @@ parse(int c, char **argv, int invert, unsigned int *flags, exit_error(PARAMETER_PROBLEM, "only --h-length 6 " "supported"); macaddr = ether_aton(argv[optind-1]); + if (macaddr == NULL) + exit_error(PARAMETER_PROBLEM, "invalid source MAC"); memcpy(mangle->src_devaddr, macaddr, e->arp.arhln); mangle->flags |= ARPT_MANGLE_SDEV; break; @@ -118,6 +120,8 @@ parse(int c, char **argv, int invert, unsigned int *flags, exit_error(PARAMETER_PROBLEM, "only --h-length 6 " "supported"); macaddr = ether_aton(argv[optind-1]); + if (macaddr == NULL) + exit_error(PARAMETER_PROBLEM, "invalid target MAC"); memcpy(mangle->tgt_devaddr, macaddr, e->arp.arhln); mangle->flags |= ARPT_MANGLE_TDEV; break; |