From 4e5e23adaad58cded55b55b6c90aa0cbc207feb2 Mon Sep 17 00:00:00 2001 From: Phil Sutter Date: Thu, 21 Nov 2019 11:59:23 +0100 Subject: Eliminate compiler warning about size passed to strncmp() Gcc complains about the size being equal to destination size, despite the nul character being explicitly set in following line. Reduce size by one to make gcc happy. While being at it, drop the explicit nul character assignment - it is not needed as the buffer was allocated by calloc(). Fixes: 8f586939999e0 ("fix potential buffer overflows reported by static analysis") Acked-by: Phil Sutter Acked-by: Pablo Neira Ayuso --- arptables.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/arptables.c b/arptables.c index 09c9ca2..2b6618c 100644 --- a/arptables.c +++ b/arptables.c @@ -2065,8 +2065,7 @@ int do_command(int argc, char *argv[], char **table, arptc_handle_t *handle) target->t = fw_calloc(1, size); target->t->u.target_size = size; - strncpy(target->t->u.user.name, jumpto, sizeof(target->t->u.user.name)); - target->t->u.user.name[sizeof(target->t->u.user.name)-1] = '\0'; + strncpy(target->t->u.user.name, jumpto, sizeof(target->t->u.user.name) - 1); target->t->u.user.revision = target->revision; /* target->init(target->t, &fw.nfcache); -- cgit v1.2.3