path: root/src/build.c
diff options
authorPablo Neira Ayuso <>2012-10-03 22:19:25 +0200
committerPablo Neira Ayuso <>2012-10-04 10:42:43 +0200
commit3f845636159298fb18b6d6c455066d0344a61bee (patch)
treed440bd11cafbfd7249aaffe5388d7eabcbc44966 /src/build.c
parenta95338a1715b025bf1b39136ba10de5907c1080b (diff)
conntrackd: fix crash if ExpectationSync is enabled on old Linux kernels
ExpectationSync requires Linux kernel >= 3.5 to work sanely, document this. Still, we don't want to crash if someone enables expectation sync with old Linux kernels (like 2.6.32). Reported-by: James Gutholm <> Tested-by: James Gutholm <> Signed-off-by: Pablo Neira Ayuso <>
Diffstat (limited to 'src/build.c')
1 files changed, 2 insertions, 1 deletions
diff --git a/src/build.c b/src/build.c
index 7d4ef12..e15eb4f 100644
--- a/src/build.c
+++ b/src/build.c
@@ -356,7 +356,8 @@ void exp2msg(const struct nf_expect *exp, struct nethdr *n)
exp_build_u32(exp, ATTR_EXP_NAT_DIR, n, NTA_EXP_NAT_DIR);
- exp_build_str(exp, ATTR_EXP_HELPER_NAME, n, NTA_EXP_HELPER_NAME);
+ if (nfexp_attr_is_set(exp, ATTR_EXP_HELPER_NAME))
+ exp_build_str(exp, ATTR_EXP_HELPER_NAME, n, NTA_EXP_HELPER_NAME);
if (nfexp_attr_is_set(exp, ATTR_EXP_FN))
exp_build_str(exp, ATTR_EXP_FN, n, NTA_EXP_FN);