diff options
| author | Jiri Popelka <jpopelka@redhat.com> | 2011-06-10 15:25:55 +0200 |
|---|---|---|
| committer | Jan Engelhardt <jengelh@medozas.de> | 2011-06-22 15:53:33 +0200 |
| commit | 96d0d0130a9a08803406c5c18681903446088ebf (patch) | |
| tree | ac8353f22f03f9386483f74759dcaa750a031c75 | |
| parent | f6677b5bcae125af28d227b9073426bddbd9190e (diff) | |
iptables: Coverity: DEADCODE
libiptc.c:407: dead_error_condition: On this path, the condition
"res > 0" cannot be false.
libiptc.c:396: at_least: After this line, the value of "res" is at
least 1.
libiptc.c:393: equality_cond: Condition "res == 0" is evaluated as
false.
libiptc.c:396: new_values: Noticing condition "res < 0".
libiptc.c:425: new_values: Noticing condition "res < 0".
libiptc.c:407: new_values: Noticing condition "res > 0".
libiptc.c:435: dead_error_line: Execution cannot reach this statement
"return list_pos;".
Signed-off-by: Jan Engelhardt <jengelh@medozas.de>
| -rw-r--r-- | libiptc/libiptc.c | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/libiptc/libiptc.c b/libiptc/libiptc.c index 0b6d5e3a..42d9784a 100644 --- a/libiptc/libiptc.c +++ b/libiptc/libiptc.c @@ -403,7 +403,7 @@ __iptcc_bsearch_chain_index(const char *name, unsigned int offset, } debug("jump back to pos:%d (end:%d)\n", pos, end); goto loop; - } else if (res > 0 ){ /* Not far enough, jump forward */ + } else { /* res > 0; Not far enough, jump forward */ /* Exit case: Last element of array */ if (pos == handle->chain_index_sz-1) { @@ -430,8 +430,6 @@ __iptcc_bsearch_chain_index(const char *name, unsigned int offset, debug("jump forward to pos:%d (end:%d)\n", pos, end); goto loop; } - - return list_pos; } /* Wrapper for string chain name based bsearch */ |