diff options
| author | Florian Westphal <fw@strlen.de> | 2022-11-18 15:20:32 +0100 |
|---|---|---|
| committer | Florian Westphal <fw@strlen.de> | 2022-11-23 09:19:01 +0100 |
| commit | 25883ce88bfba087ef142cb909d59dbbc1818b32 (patch) | |
| tree | 06d7347a6239f9ef36aa6653df685264d03da5fc /iptables/nft-bridge.c | |
| parent | c9d41cefbe6eafb4a6b12c69fc1fa54b716d6c99 (diff) | |
nft: check for unknown meta keys
Set ->errmsg when the meta key isn't supported by iptables-nft instead
of pretending everything is fine.
The old code is good enough to handle rules added by iptables-nft, but
its not enough to handle rules added by native nft.
At least make sure that there is a an error message telling that
iptables-nft could not decode the entire ruleset.
Signed-off-by: Florian Westphal <fw@strlen.de>
Diffstat (limited to 'iptables/nft-bridge.c')
| -rw-r--r-- | iptables/nft-bridge.c | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/iptables/nft-bridge.c b/iptables/nft-bridge.c index 749cbc6f..e8ac7a36 100644 --- a/iptables/nft-bridge.c +++ b/iptables/nft-bridge.c @@ -197,7 +197,10 @@ static void nft_bridge_parse_meta(struct nft_xt_ctx *ctx, uint8_t invflags = 0; char iifname[IFNAMSIZ] = {}, oifname[IFNAMSIZ] = {}; - parse_meta(ctx, e, reg->meta_dreg.key, iifname, NULL, oifname, NULL, &invflags); + if (parse_meta(ctx, e, reg->meta_dreg.key, iifname, NULL, oifname, NULL, &invflags) < 0) { + ctx->errmsg = "unknown meta key"; + return; + } switch (reg->meta_dreg.key) { case NFT_META_BRI_IIFNAME: @@ -221,6 +224,7 @@ static void nft_bridge_parse_meta(struct nft_xt_ctx *ctx, snprintf(fw->out, sizeof(fw->out), "%s", oifname); break; default: + ctx->errmsg = "unknown bridge meta key"; break; } } |