diff options
| author | Phil Sutter <phil@nwl.cc> | 2019-01-31 16:12:55 +0100 |
|---|---|---|
| committer | Florian Westphal <fw@strlen.de> | 2019-01-31 22:54:12 +0100 |
| commit | 84331e3ed3f8eb9d53c00c221113ad16b209968a (patch) | |
| tree | 3c23a42a1c372c7f803684cbd7b7f21d1ab25313 /iptables/tests/shell/testcases/arptables/0002-arptables-restore-defaults_0 | |
| parent | 2c3f7a2cd6fd8325b3a84e280cce945c6c20b87f (diff) | |
arptables-nft: Don't print default h-len/h-type values
Default values for --h-len and --h-type being printed for rules where
user didn't provide them is unexpected and confusing. The drawback is
the opposite: If user provided either of them with their default value,
they are later omitted when listing rules. Though since unlike legacy
arptables we can't distinguish between not specified and specified with
default value, we can't fix both - so choose to optimize for the more
likely case.
Fixes: 5aecb2d8bfdda ("arptables: pre-init hlen and ethertype")
Signed-off-by: Phil Sutter <phil@nwl.cc>
Signed-off-by: Florian Westphal <fw@strlen.de>
Diffstat (limited to 'iptables/tests/shell/testcases/arptables/0002-arptables-restore-defaults_0')
| -rwxr-xr-x | iptables/tests/shell/testcases/arptables/0002-arptables-restore-defaults_0 | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/iptables/tests/shell/testcases/arptables/0002-arptables-restore-defaults_0 b/iptables/tests/shell/testcases/arptables/0002-arptables-restore-defaults_0 index d742c3d5..b2ed95e8 100755 --- a/iptables/tests/shell/testcases/arptables/0002-arptables-restore-defaults_0 +++ b/iptables/tests/shell/testcases/arptables/0002-arptables-restore-defaults_0 @@ -11,7 +11,7 @@ set -e DUMP='*filter :OUTPUT ACCEPT -A OUTPUT -j mangle --mangle-ip-s 10.0.0.1 --A OUTPUT -j mangle --h-length 6 --h-type 1 --mangle-ip-d 10.0.0.2 +-A OUTPUT -j mangle --mangle-ip-d 10.0.0.2 ' # note how mangle-ip-s is unset in second rule @@ -19,8 +19,8 @@ DUMP='*filter EXPECT='*filter :INPUT ACCEPT :OUTPUT ACCEPT --A OUTPUT -j mangle --h-length 6 --h-type 1 --mangle-ip-s 10.0.0.1 --A OUTPUT -j mangle --h-length 6 --h-type 1 --mangle-ip-d 10.0.0.2 +-A OUTPUT -j mangle --mangle-ip-s 10.0.0.1 +-A OUTPUT -j mangle --mangle-ip-d 10.0.0.2 ' $XT_MULTI arptables -F |