From 11e91a4875b443450dc08951efd6a595d3f5df2e Mon Sep 17 00:00:00 2001 From: Phil Sutter Date: Wed, 19 Sep 2018 15:17:06 +0200 Subject: xtables: Don't read garbage in nft_ipv4_parse_payload() The problem here is that get_frag() does not set 'inv' in any case, so when later checking its value, garbage may be read. Sanitize this case by setting 'inv' to false before calling get_frag(). Signed-off-by: Phil Sutter Signed-off-by: Florian Westphal --- iptables/nft-ipv4.c | 1 + 1 file changed, 1 insertion(+) diff --git a/iptables/nft-ipv4.c b/iptables/nft-ipv4.c index 20ed9428..39e61844 100644 --- a/iptables/nft-ipv4.c +++ b/iptables/nft-ipv4.c @@ -234,6 +234,7 @@ static void nft_ipv4_parse_payload(struct nft_xt_ctx *ctx, break; case offsetof(struct iphdr, frag_off): cs->fw.ip.flags |= IPT_F_FRAG; + inv = false; get_frag(ctx, e, &inv); if (inv) cs->fw.ip.invflags |= IPT_INV_FRAG; -- cgit v1.2.3