From 4c54c892443c20a1d0e1212d541da0e81647058a Mon Sep 17 00:00:00 2001 From: Phil Sutter Date: Sat, 15 Dec 2018 19:25:04 +0100 Subject: xtables: Catch errors when zeroing rule rounters Covscan complained about call to batch_rule_add() not being checked. Signed-off-by: Phil Sutter Signed-off-by: Florian Westphal --- iptables/nft.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/iptables/nft.c b/iptables/nft.c index 2fa973cf..8d0d1017 100644 --- a/iptables/nft.c +++ b/iptables/nft.c @@ -2991,7 +2991,9 @@ static int __nft_chain_zero_counters(struct nftnl_chain *c, void *data) * rule based on its handle only. */ nftnl_rule_unset(r, NFTNL_RULE_POSITION); - batch_rule_add(h, NFT_COMPAT_RULE_REPLACE, r); + ret = batch_rule_add(h, NFT_COMPAT_RULE_REPLACE, r); + if (ret) + return -1; } r = nftnl_rule_iter_next(iter); } -- cgit v1.2.3