From bbe83862a5e1baf15f7c923352d4afdf59bc70e2 Mon Sep 17 00:00:00 2001 From: Jan Engelhardt Date: Sat, 24 Oct 2009 00:45:33 +0200 Subject: iptables/extensions: make bundled options work again When using a bundled option like "-ptcp", 'argv[optind-1]' would logically point to "-ptcp", but this is obviously not right. 'optarg' is needed instead, which if properly offset to "tcp". Not all places change optind-based access to optarg; where look-ahead is needed, such as for tcp's --tcp-flags option for example, optind is ok. References: http://bugzilla.netfilter.org/show_bug.cgi?id=611 Signed-off-by: Jan Engelhardt --- extensions/libxt_u32.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'extensions/libxt_u32.c') diff --git a/extensions/libxt_u32.c b/extensions/libxt_u32.c index 8e149c1b..9a61c8a5 100644 --- a/extensions/libxt_u32.c +++ b/extensions/libxt_u32.c @@ -107,7 +107,7 @@ static int u32_parse(int c, char **argv, int invert, unsigned int *flags, struct xt_u32 *data = (void *)(*match)->data; unsigned int testind = 0, locind = 0, valind = 0; struct xt_u32_test *ct = &data->tests[testind]; /* current test */ - char *arg = argv[optind-1]; /* the argument string */ + char *arg = optarg; /* the argument string */ char *start = arg; int state = 0; -- cgit v1.2.3