From 99164705ed74333d9e7e3f2e16f510749233fded Mon Sep 17 00:00:00 2001 From: Liping Zhang Date: Sat, 21 May 2016 18:07:16 +0800 Subject: extensions: libxt_limit: fix a wrong translation to nft rule The default burst value is 5 in iptables limit extension while it is 0 in nft limit expression, if the burst value is default, it will not be displayed when we dump the rules. But when we do translation from iptables rules to nft rules, we should keep the limit burst value unchanged, even if it is not displayed in iptables rules. And now, if the limit-burst value in the iptables rule is 5 or 0, they are all translated to nft rule without burst, this is wrong: $ sudo iptables-translate -A INPUT -m limit --limit 10/s --limit-burst 5 nft add rule ip filter INPUT limit rate 10/second counter $ sudo iptables-translate -A INPUT -m limit --limit 10/s --limit-burst 0 nft add rule ip filter INPUT limit rate 10/second burst 0 packets counter Apply this patch, translation will become: $ sudo iptables-translate -A INPUT -m limit --limit 10/s --limit-burst 5 nft add rule ip filter INPUT limit rate 10/second burst 5 packets counter $ sudo iptables-translate -A INPUT -m limit --limit 10/s --limit-burst 0 nft add rule ip filter INPUT limit rate 10/second counter Fixes: a8dfbe3a3acb ("extensions: libxt_limit: Add translation to nft") Cc: Shivani Bhardwaj Signed-off-by: Liping Zhang Signed-off-by: Pablo Neira Ayuso --- extensions/libxt_limit.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'extensions') diff --git a/extensions/libxt_limit.c b/extensions/libxt_limit.c index c88d26b8..6652849a 100644 --- a/extensions/libxt_limit.c +++ b/extensions/libxt_limit.c @@ -184,7 +184,7 @@ static int limit_xlate(const void *ip, const struct xt_entry_match *match, xt_xlate_add(xl, "limit rate"); print_rate_xlate(r->avg, xl); - if (r->burst != XT_LIMIT_BURST) + if (r->burst != 0) xt_xlate_add(xl, "burst %u packets ", r->burst); return 1; -- cgit v1.2.3