From 1e128bd804b676ee91beca48312de9b251845d09 Mon Sep 17 00:00:00 2001 From: Jan Engelhardt Date: Sat, 8 Jan 2011 02:25:28 +0100 Subject: ip[6]tables: only call match's parse function when option char is in range Normally, extensions use a "default:" case in switch(c) to just return if they do not handle c. Apparently, libip6t_hl does that too late and checks for hl-specific parsing state before it has established that c refers to one of its own options. Also affected: libipt_ttl, libxt_ipvs, libxt_policy, libxt_statistic. One way to fix this is to move the flags checks into case '2', '3', '4'. Doing this replication feels bad, so as an alternative, let's just free extensions from having to deal with other extension's options passing thru. References: http://marc.info/?l=netfilter-devel&m=129444759532377&w=2 Signed-off-by: Jan Engelhardt --- iptables.c | 3 +++ 1 file changed, 3 insertions(+) (limited to 'iptables.c') diff --git a/iptables.c b/iptables.c index e0efbf1b..bcacd49f 100644 --- a/iptables.c +++ b/iptables.c @@ -1746,6 +1746,9 @@ int do_command(int argc, char *argv[], char **table, struct iptc_handle **handle if (matchp->completed || matchp->match->parse == NULL) continue; + if (c < matchp->match->option_offset || + c >= matchp->match->option_offset + XT_OPTION_OFFSET_SCALE) + continue; if (matchp->match->parse(c - matchp->match->option_offset, argv, invert, &matchp->match->mflags, -- cgit v1.2.3