From 7e50ebabbf9c3a5eeb9511d9f32c6104b56da5cd Mon Sep 17 00:00:00 2001 From: Phil Sutter Date: Wed, 19 Sep 2018 15:17:04 +0200 Subject: Fix a few cases of pointless assignments This gets rid of a number of assignments which are either redundant or not used afterwards. Signed-off-by: Phil Sutter Signed-off-by: Florian Westphal --- iptables/xtables-restore.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'iptables/xtables-restore.c') diff --git a/iptables/xtables-restore.c b/iptables/xtables-restore.c index 9d15593f..d9faa4d0 100644 --- a/iptables/xtables-restore.c +++ b/iptables/xtables-restore.c @@ -266,7 +266,6 @@ void xtables_restore_parse(struct nft_handle *h, } else if (in_table) { int a; - char *ptr = buffer; char *pcnt = NULL; char *bcnt = NULL; char *parsestart; @@ -276,7 +275,8 @@ void xtables_restore_parse(struct nft_handle *h, if (buffer[0] == '[') { /* we have counters in our input */ - ptr = strchr(buffer, ']'); + char *ptr = strchr(buffer, ']'); + if (!ptr) xtables_error(PARAMETER_PROBLEM, "Bad line %u: need ]\n", -- cgit v1.2.3