From 735f3d76ccd3a7deab13703d7c227c87c666a97b Mon Sep 17 00:00:00 2001 From: Jan Engelhardt Date: Sun, 21 Aug 2011 10:14:28 +0200 Subject: xtoptions: flag use of XTOPT_POINTER without XTOPT_PUT When XTOPT_POINTER is used (and yields a non-zero offsetof), we can flag the absence of XTOPT_PUT. Signed-off-by: Jan Engelhardt --- iptables/xtoptions.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) (limited to 'iptables/xtoptions.c') diff --git a/iptables/xtoptions.c b/iptables/xtoptions.c index 7095e3ea..04344af4 100644 --- a/iptables/xtoptions.c +++ b/iptables/xtoptions.c @@ -847,8 +847,14 @@ void xtables_option_metavalidate(const char *name, xt_params->exit_err(OTHER_PROBLEM, "Extension %s uses invalid ID %u\n", name, entry->id); - if (!(entry->flags & XTOPT_PUT)) + if (!(entry->flags & XTOPT_PUT)) { + if (entry->ptroff != 0) + xt_params->exit_err(OTHER_PROBLEM, + "%s: ptroff for \"--%s\" is non-" + "zero but no XTOPT_PUT is specified. " + "Oversight?", name, entry->name); continue; + } if (entry->type >= ARRAY_SIZE(xtopt_psize) || xtopt_psize[entry->type] == 0) xt_params->exit_err(OTHER_PROBLEM, -- cgit v1.2.3