From 64ff47cde38e48b621883947fd61b9b1357f9451 Mon Sep 17 00:00:00 2001 From: Jesper Dangaard Brouer Date: Mon, 23 Mar 2009 14:25:49 +0100 Subject: libiptc: fix chain rename bug in libiptc Chain renaming (TC_RENAME_CHAIN) can result in an unsorted chain list. That breaks the requirement of the binary search done in iptcc_bsearch_chain_index(). Signed-off-by: Jesper Dangaard Brouer Signed-off-by: Patrick McHardy --- libiptc/libiptc.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) (limited to 'libiptc') diff --git a/libiptc/libiptc.c b/libiptc/libiptc.c index c3d9bfc8..6b3a1fbe 100644 --- a/libiptc/libiptc.c +++ b/libiptc/libiptc.c @@ -2404,8 +2404,15 @@ int TC_RENAME_CHAIN(const IPT_CHAINLABEL oldname, return 0; } + /* This only unlinks "c" from the list, thus no free(c) */ + iptcc_chain_index_delete_chain(c, handle); + + /* Change the name of the chain */ strncpy(c->name, newname, sizeof(IPT_CHAINLABEL)); - + + /* Insert sorted into to list again */ + iptc_insert_chain(handle, c); + set_changed(handle); return 1; -- cgit v1.2.3