From 9b3fd1352c9806ef5acc10f38b1131bc2f62b60c Mon Sep 17 00:00:00 2001 From: Phil Oester Date: Tue, 8 Oct 2013 09:20:15 -0700 Subject: iptables: spurious error in load_extension In commit 927385017047d (iptables: improve error reporting with extension loading troubles), a new error message was added in an attempt to handle the case where a match does not support a particular protocol family. For instance, attempting to use the osf match on IPv6. Unfortunately, this error message now triggers when creating a new chain which has the same name as a match extension, because iptables calls xtables_find_target with the name of the new chain to verify it does not clash with an existing target. For example: # iptables -N tcp /usr/lib/xtables/libxt_tcp.so: no "tcp" extension found for this protocol I attempted to resolve this by adding a new XTF flag, but that required changes in many different places (including -j handling). It seems easiest just to remove this warning and stick with the original error message of ENOENT, even if less than precise. Signed-off-by: Phil Oester Signed-off-by: Pablo Neira Ayuso --- libxtables/xtables.c | 2 -- 1 file changed, 2 deletions(-) (limited to 'libxtables/xtables.c') diff --git a/libxtables/xtables.c b/libxtables/xtables.c index 8437baf8..fb60c01b 100644 --- a/libxtables/xtables.c +++ b/libxtables/xtables.c @@ -578,8 +578,6 @@ static void *load_extension(const char *search_path, const char *af_prefix, if (ptr != NULL) return ptr; - fprintf(stderr, "%s: no \"%s\" extension found for " - "this protocol\n", path, name); errno = ENOENT; return NULL; } -- cgit v1.2.3