From c29d99c83d95ca063fd378bd0b7f798eb66163fb Mon Sep 17 00:00:00 2001 From: Oliver Ford Date: Fri, 5 May 2017 11:11:50 +0000 Subject: libxtables: Display weird character warning for wildcards Change the scope of the weird character check loop so that it checks for invalid characters when the interface name contains a wildcard. Fixes Bugzilla #1085. Signed-off-by: Oliver Ford Signed-off-by: Pablo Neira Ayuso --- libxtables/xtables.c | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) (limited to 'libxtables/xtables.c') diff --git a/libxtables/xtables.c b/libxtables/xtables.c index 891d81a7..57a11022 100644 --- a/libxtables/xtables.c +++ b/libxtables/xtables.c @@ -538,15 +538,15 @@ void xtables_parse_interface(const char *arg, char *vianame, } else { /* Include nul-terminator in match */ memset(mask, 0xFF, vialen + 1); - for (i = 0; vianame[i]; i++) { - if (vianame[i] == '/' || - vianame[i] == ' ') { - fprintf(stderr, - "Warning: weird character in interface" - " `%s' ('/' and ' ' are not allowed by the kernel).\n", - vianame); - break; - } + } + + /* Display warning on invalid characters */ + for (i = 0; vianame[i]; i++) { + if (vianame[i] == '/' || vianame[i] == ' ') { + fprintf(stderr, "Warning: weird character in interface" + " `%s' ('/' and ' ' are not allowed by the kernel).\n", + vianame); + break; } } } -- cgit v1.2.3