diff options
author | Jan Engelhardt <jengelh@medozas.de> | 2010-12-30 22:54:57 +0100 |
---|---|---|
committer | Jan Engelhardt <jengelh@medozas.de> | 2010-12-30 22:56:31 +0100 |
commit | f1456fa807f20bf8dd73ab3ae3312c2e8187f89f (patch) | |
tree | e1ae3ee5477cf69c2d46d40a3422029f37c84469 | |
parent | 6d495ef76ec6b2d7925d3018ce6e19e41ed4be9f (diff) |
qa: resolve compiler warnings
-Wall flags this:
make test_api test_filter
make[1]: Entering directory `/home/jengelh/code/libnetfilter_conntrack/qa'
CC test_api.o
test_api.c:16:8: warning: return type defaults to "int"
test_api.c: In function "eval_sigterm":
test_api.c:23:18: warning: too many arguments for format
test_api.c: In function "main":
test_api.c:55:2: warning: implicit declaration of function "fork"
test_api.c:34:22: warning: unused variable "h"
test_api.c:102:1: warning: control reaches end of non-void function
test_api.c: In function "eval_sigterm":
test_api.c:29:1: warning: control reaches end of non-void function
CCLD test_api
CC test_filter.o
test_filter.c: In function "main":
test_filter.c:58:4: warning: implicit declaration of function "inet_addr"
test_filter.c:74:2: warning: implicit declaration of function "strerror"
test_filter.c:74:2: warning: format "%s" expects type ‘char *’, but argument 3 has type ‘int’
test_filter.c:75:1: warning: control reaches end of non-void function
CCLD test_filter
make[1]: Leaving directory `/home/jengelh/code/libnetfilter_conntrack/qa'
Signed-off-by: Jan Engelhardt <jengelh@medozas.de>
-rw-r--r-- | qa/test_api.c | 9 | ||||
-rw-r--r-- | qa/test_filter.c | 6 |
2 files changed, 10 insertions, 5 deletions
diff --git a/qa/test_api.c b/qa/test_api.c index eda9d49..e7a8453 100644 --- a/qa/test_api.c +++ b/qa/test_api.c @@ -4,6 +4,7 @@ #include <stdio.h> #include <stdlib.h> +#include <unistd.h> #include <sys/wait.h> #include <errno.h> @@ -13,14 +14,14 @@ * this file contains a test to check the set/get/copy/cmp APIs. */ -static eval_sigterm(int status) +static void eval_sigterm(int status) { switch(WTERMSIG(status)) { case SIGSEGV: printf("received SIGSEV\n"); break; case 0: - printf("OK\n", WTERMSIG(status)); + printf("OK\n"); break; default: printf("exited with signal: %d\n", WTERMSIG(status)); @@ -28,10 +29,9 @@ static eval_sigterm(int status) } } -int main() +int main(void) { int ret, i; - struct nfct_handle *h; struct nf_conntrack *ct, *tmp; char data[32]; int status; @@ -99,4 +99,5 @@ int main() nfct_destroy(ct); nfct_destroy(tmp); + return EXIT_SUCCESS; } diff --git a/qa/test_filter.c b/qa/test_filter.c index 35fdbec..7877819 100644 --- a/qa/test_filter.c +++ b/qa/test_filter.c @@ -3,6 +3,9 @@ */ #include <stdio.h> +#include <stdlib.h> +#include <string.h> +#include <arpa/inet.h> #include <errno.h> #include <libnetfilter_conntrack/libnetfilter_conntrack.h> @@ -23,7 +26,7 @@ static int event_cb(enum nf_conntrack_msg_type type, return NFCT_CB_CONTINUE; } -int main() +int main(void) { int i, ret; struct nfct_handle *h; @@ -72,4 +75,5 @@ int main() ret = nfct_catch(h); printf("test ret=%d (%s)\n", ret, strerror(errno)); + return EXIT_SUCCESS; } |