path: root/extensions/libnetfilter_conntrack_tcp.c
diff options
author/C=DE/ST=Berlin/L=Berlin/O=Netfilter Project/OU=Development/CN=pablo/ </C=DE/ST=Berlin/L=Berlin/O=Netfilter Project/OU=Development/CN=pablo/>2005-10-31 04:20:58 +0000
committer/C=DE/ST=Berlin/L=Berlin/O=Netfilter Project/OU=Development/CN=pablo/ </C=DE/ST=Berlin/L=Berlin/O=Netfilter Project/OU=Development/CN=pablo/>2005-10-31 04:20:58 +0000
commit837747610f4c8046889aacd3f29f1f63049015cc (patch)
tree70230f11e831a38745c4863b5235585a53e8a0f4 /extensions/libnetfilter_conntrack_tcp.c
parentf03dacaf6b7afb221a779cdc3ad6953a6aa770d7 (diff)
Special thanks to Deti Fiegl from the Leibniz Supercomputing Centre in Munich, Germany for providing the "fast" hardware to reproduce spurious bugs ;)
List of changes: o Replace misleading flag NFCT_ANY_GROUP by NFCT_ALL_GROUPS o Update test file to use NFCT_ALL_GROUPS o Add missing check of CTA_PROTOINFO_TCP that resulted in a segfault in conjuction with events. o Fix ICMP conntracks output o Add missing prototype definition of nfct_default_expect_display_id in libnetfilter_conntrack.h
Diffstat (limited to 'extensions/libnetfilter_conntrack_tcp.c')
1 files changed, 12 insertions, 0 deletions
diff --git a/extensions/libnetfilter_conntrack_tcp.c b/extensions/libnetfilter_conntrack_tcp.c
index 32a0971..bb96698 100644
--- a/extensions/libnetfilter_conntrack_tcp.c
+++ b/extensions/libnetfilter_conntrack_tcp.c
@@ -42,6 +42,18 @@ static void parse_proto(struct nfattr *cda[], struct nfct_tuple *tuple)
static void parse_protoinfo(struct nfattr *cda[], struct nfct_conntrack *ct)
struct nfattr *tb[CTA_PROTOINFO_TCP_MAX];
+ /*
+ * Listen to me carefully: This is easy to trigger with events ;).
+ * The conntrack event messages don't always contain all the
+ * information about a conntrack, just those fields that have changed.
+ * So you can receive a message about a TCP connection with no bits
+ * talking about the private protocol information.
+ *
+ * --pablo 05/10/31
+ */
+ if (!cda[CTA_PROTOINFO_TCP-1])
+ return;
nfnl_parse_nested(tb,CTA_PROTOINFO_TCP_MAX, cda[CTA_PROTOINFO_TCP-1]);