snprintf: remove duplicated protocol string definitions

This patch merges duplicated protocol string definitions in the
snprintf infrastructure. I have also fixed the size of the string
array. This patch is a cleanup.

Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>

1 files changed, 55 insertions, 0 deletions

diff --git a/src/conntrack/snprintf.c b/src/conntrack/snprintf.c
index cc68293..80629a7 100644
--- a/src/conntrack/snprintf.c
+++ b/src/conntrack/snprintf.c
@@ -7,6 +7,61 @@
 
 #include "internal/internal.h"
 
+/* these arrays are used by snprintf_default.c and snprintf_xml.c */
+const char *l3proto2str[AF_MAX] = {
+	[AF_INET]			= "ipv4",
+	[AF_INET6]			= "ipv6",
+};
+
+const char *proto2str[IPPROTO_MAX] = {
+	[IPPROTO_TCP]			= "tcp",
+	[IPPROTO_UDP]			= "udp",
+	[IPPROTO_UDPLITE]		= "udplite",
+	[IPPROTO_ICMP]			= "icmp",
+	[IPPROTO_ICMPV6]		= "icmpv6",
+	[IPPROTO_SCTP]			= "sctp",
+	[IPPROTO_GRE]			= "gre",
+	[IPPROTO_UDPLITE]		= "udplite",
+	[IPPROTO_DCCP]			= "dccp",
+};
+
+const char *states[TCP_CONNTRACK_MAX] = {
+	[TCP_CONNTRACK_NONE]		= "NONE",
+	[TCP_CONNTRACK_SYN_SENT]	= "SYN_SENT",
+	[TCP_CONNTRACK_SYN_RECV]	= "SYN_RECV",
+	[TCP_CONNTRACK_ESTABLISHED]	= "ESTABLISHED",
+	[TCP_CONNTRACK_FIN_WAIT]	= "FIN_WAIT",
+	[TCP_CONNTRACK_CLOSE_WAIT]	= "CLOSE_WAIT",
+	[TCP_CONNTRACK_LAST_ACK]	= "LAST_ACK",
+	[TCP_CONNTRACK_TIME_WAIT]	= "TIME_WAIT",
+	[TCP_CONNTRACK_CLOSE]		= "CLOSE",
+	[TCP_CONNTRACK_LISTEN]		= "LISTEN",
+};
+
+const char *sctp_states[SCTP_CONNTRACK_MAX] = {
+	[SCTP_CONNTRACK_NONE]		= "NONE",
+	[SCTP_CONNTRACK_CLOSED]		= "CLOSED",
+	[SCTP_CONNTRACK_COOKIE_WAIT]	= "COOKIE_WAIT",
+	[SCTP_CONNTRACK_COOKIE_ECHOED]	= "COOKIE_ECHOED",
+	[SCTP_CONNTRACK_ESTABLISHED]	= "ESTABLISHED",
+	[SCTP_CONNTRACK_SHUTDOWN_SENT]	= "SHUTDOWN_SENT",
+	[SCTP_CONNTRACK_SHUTDOWN_RECD]	= "SHUTDOWN_RECD",
+	[SCTP_CONNTRACK_SHUTDOWN_ACK_SENT] = "SHUTDOWN_ACK_SENT",
+};
+
+const char *dccp_states[DCCP_CONNTRACK_MAX] = {
+	[DCCP_CONNTRACK_NONE]		= "NONE",
+	[DCCP_CONNTRACK_REQUEST]	= "REQUEST",
+	[DCCP_CONNTRACK_RESPOND]	= "RESPOND",
+	[DCCP_CONNTRACK_PARTOPEN]	= "PARTOPEN",
+	[DCCP_CONNTRACK_OPEN]		= "OPEN",
+	[DCCP_CONNTRACK_CLOSEREQ]	= "CLOSEREQ",
+	[DCCP_CONNTRACK_CLOSING]	= "CLOSING",
+	[DCCP_CONNTRACK_TIMEWAIT]	= "TIMEWAIT",
+	[DCCP_CONNTRACK_IGNORE]		= "IGNORE",
+	[DCCP_CONNTRACK_INVALID]	= "INVALID",
+};
+
 int __snprintf_conntrack(char *buf,
 			 unsigned int len,
 			 const struct nf_conntrack *ct,