diff options
author | Jiri Popelka <jpopelka@redhat.com> | 2011-06-10 11:12:15 +0200 |
---|---|---|
committer | Pablo Neira Ayuso <pablo@netfilter.org> | 2011-06-13 19:52:49 +0200 |
commit | 75c69a3da6ae268f42aecca7e5ae79dacdd87414 (patch) | |
tree | 0f1c3de3e6113c194b8d1dab86305548d810d521 /src/conntrack | |
parent | af0ed4892ba998e958e6da52cbdcf900fdd391e9 (diff) |
conntrack: objopt: NO_EFFECT
static analysis (analysis based only on compiling of sources, not based
on running of binary) of the code revealed the following problem:
conntrack/objopt.c:63: self_assign: Assignment operation
"ct->snat.l4max.all = ct->snat.l4max.all"
has no effect.
Signed-off-by: Jiri Popelka <jpopelka@redhat.com>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
Diffstat (limited to 'src/conntrack')
-rw-r--r-- | src/conntrack/objopt.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/conntrack/objopt.c b/src/conntrack/objopt.c index 7e6e5e2..6180663 100644 --- a/src/conntrack/objopt.c +++ b/src/conntrack/objopt.c @@ -60,7 +60,7 @@ static void setobjopt_undo_dnat(struct nf_conntrack *ct) static void setobjopt_undo_spat(struct nf_conntrack *ct) { ct->snat.l4min.all = ct->tuple[__DIR_REPL].l4dst.tcp.port; - ct->snat.l4max.all = ct->snat.l4max.all; + ct->snat.l4max.all = ct->snat.l4min.all; ct->tuple[__DIR_REPL].l4dst.tcp.port = ct->tuple[__DIR_ORIG].l4src.tcp.port; set_bit(ATTR_SNAT_PORT, ct->set); |