diff options
author | Phil Sutter <phil@nwl.cc> | 2022-03-25 14:55:53 +0100 |
---|---|---|
committer | Phil Sutter <phil@nwl.cc> | 2022-03-29 23:31:03 +0200 |
commit | 86f5bdc2a85b208053e7361ccd575e4eb3c853a3 (patch) | |
tree | 554e84c61e51afabb0bd421377908ff2dddb33e2 /src/conntrack | |
parent | 21ee35dde73aec5eba35290587d479218c6dd824 (diff) |
expect/conntrack: Avoid spurious covscan overrun warning
It doesn't like how memset() is called for a struct nfnlhdr pointer with
large size value. Pass void pointers instead. This also removes the call
from __build_{expect,conntrack}() which is duplicate in
__build_query_{exp,ct}() code-path.
Signed-off-by: Phil Sutter <phil@nwl.cc>
Diffstat (limited to 'src/conntrack')
-rw-r--r-- | src/conntrack/api.c | 4 | ||||
-rw-r--r-- | src/conntrack/build.c | 2 |
2 files changed, 3 insertions, 3 deletions
diff --git a/src/conntrack/api.c b/src/conntrack/api.c index b7f64fb..7f72d07 100644 --- a/src/conntrack/api.c +++ b/src/conntrack/api.c @@ -779,6 +779,8 @@ int nfct_build_conntrack(struct nfnl_subsys_handle *ssh, assert(req != NULL); assert(ct != NULL); + memset(req, 0, size); + return __build_conntrack(ssh, req, size, type, flags, ct); } @@ -812,7 +814,7 @@ __build_query_ct(struct nfnl_subsys_handle *ssh, assert(data != NULL); assert(req != NULL); - memset(req, 0, size); + memset(buffer, 0, size); switch(qt) { case NFCT_Q_CREATE: diff --git a/src/conntrack/build.c b/src/conntrack/build.c index b5a7061..f80cfc1 100644 --- a/src/conntrack/build.c +++ b/src/conntrack/build.c @@ -27,8 +27,6 @@ int __build_conntrack(struct nfnl_subsys_handle *ssh, return -1; } - memset(req, 0, size); - buf = (char *)&req->nlh; nlh = mnl_nlmsg_put_header(buf); nlh->nlmsg_type = (NFNL_SUBSYS_CTNETLINK << 8) | type; |