diff options
author | Florian Westphal <fw@strlen.de> | 2013-05-31 17:35:41 +0200 |
---|---|---|
committer | Florian Westphal <fw@strlen.de> | 2013-06-02 19:03:37 +0200 |
commit | 044fcf5f4c1e94e0c57876b2a98fc4a7975498d0 (patch) | |
tree | 81c226097e6e8f0cb641c47a32c9ab577789a4b8 /src/expect/compare.c | |
parent | e6f31bf4346007b4bf64a81ba1843da03663789d (diff) |
conntrack, expect: fix _cmp api with STRICT checking
Normal comparision succeeds when the _common_ attribute subset
have same values.
When STRICT matching is specified, the comparision should succeed only when
both objects have same attribute subset and attribute values match.
However, STRICT comparision often fails as an attribute missing in both
objects is erronously considered an error.
Signed-off-by: Florian Westphal <fw@strlen.de>
Diffstat (limited to 'src/expect/compare.c')
-rw-r--r-- | src/expect/compare.c | 7 |
1 files changed, 6 insertions, 1 deletions
diff --git a/src/expect/compare.c b/src/expect/compare.c index a524f4c..484d7b1 100644 --- a/src/expect/compare.c +++ b/src/expect/compare.c @@ -18,8 +18,13 @@ static int exp_cmp(int attr, const struct nf_expect *exp2, unsigned int flags)) { - if (test_bit(attr, exp1->set) && test_bit(attr, exp2->set)) { + int a = test_bit(attr, exp1->set); + int b = test_bit(attr, exp2->set); + + if (a && b) { return cmp(exp1, exp2, flags); + } else if (!a && !b) { + return 1; } else if (flags & NFCT_CMP_MASK && test_bit(attr, exp1->set)) { return 0; |