summaryrefslogtreecommitdiffstats
path: root/src
diff options
context:
space:
mode:
authorPablo Neira Ayuso <pablo@netfilter.org>2011-01-21 11:10:59 +0100
committerPablo Neira Ayuso <pablo@netfilter.org>2011-01-21 11:10:59 +0100
commitb5877dceae52efc9aac741e5fb6ba97a8ffb9225 (patch)
tree8a6b1e0bacac9bac9b64df5df0116670a0025f3c /src
parentfdda1474cc8654430f245b7f01c30e8ff171fa60 (diff)
api: fix use-after-free bug in nfct_destroy()
This patch fixes an embarasing a use-after-free in nfct_destroy() that was introduced by myself in: http://git.netfilter.org/cgi-bin/gitweb.cgi?p=libnetfilter_conntrack.git;a=commit;h=fdda1474cc8654430f245b7f01c30e8ff171fa60 Reported-by: Florian Westphal <fw@strlen.de> Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
Diffstat (limited to 'src')
-rw-r--r--src/conntrack/api.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/src/conntrack/api.c b/src/conntrack/api.c
index 8e5b2fe..6b73817 100644
--- a/src/conntrack/api.c
+++ b/src/conntrack/api.c
@@ -89,9 +89,9 @@ struct nf_conntrack *nfct_new(void)
void nfct_destroy(struct nf_conntrack *ct)
{
assert(ct != NULL);
- free(ct);
if (ct->secctx)
free(ct->secctx);
+ free(ct);
ct = NULL; /* bugtrap */
}