From 1ba9d4fff32f814a91b67a7b3de1e97367fd84f2 Mon Sep 17 00:00:00 2001 From: Pablo Neira Ayuso Date: Wed, 1 Apr 2020 18:42:58 +0200 Subject: expect: parse_mnl: fix gcc compile warning MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit parse_mnl.c: In function ‘nfexp_nlmsg_parse’: parse_mnl.c:142:3: warning: ‘strncpy’ specified bound 16 equals destination size [-Wstringop-truncation] 142 | strncpy(exp->helper_name, | ^~~~~~~~~~~~~~~~~~~~~~~~~ 143 | mnl_attr_get_str(tb[CTA_EXPECT_HELP_NAME]), | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 144 | NFCT_HELPER_NAME_MAX); | ~~~~~~~~~~~~~~~~~~~~~ Signed-off-by: Pablo Neira Ayuso --- src/expect/parse_mnl.c | 1 + 1 file changed, 1 insertion(+) (limited to 'src') diff --git a/src/expect/parse_mnl.c b/src/expect/parse_mnl.c index e7bbc16..091a8ae 100644 --- a/src/expect/parse_mnl.c +++ b/src/expect/parse_mnl.c @@ -142,6 +142,7 @@ int nfexp_nlmsg_parse(const struct nlmsghdr *nlh, struct nf_expect *exp) strncpy(exp->helper_name, mnl_attr_get_str(tb[CTA_EXPECT_HELP_NAME]), NFCT_HELPER_NAME_MAX); + exp->helper_name[NFCT_HELPER_NAME_MAX - 1] = '\0'; set_bit(ATTR_EXP_HELPER_NAME, exp->set); } if (tb[CTA_EXPECT_CLASS]) { -- cgit v1.2.3