diff options
| author | Matt Turner <mattst88@gmail.com> | 2018-10-17 12:32:54 -0700 |
|---|---|---|
| committer | Pablo Neira Ayuso <pablo@netfilter.org> | 2018-10-19 14:56:08 +0200 |
| commit | dc240913458d591f59b52b3899d3fc3c5d6ec6ce (patch) | |
| tree | b43acfe0306f2ab42a5f5abccc42420fe6a5508c /src/chain.c | |
| parent | aecc936180d302947ecfab5dacf267a701a5d84c (diff) | |
src: Use memcpy() to handle potentially unaligned data
Rolf Eike Beer <eike@sf-mail.de> reported that nft-expr_quota-test fails
with a SIGBUS on SPARC due to unaligned accesses. This patch resolves
that and fixes additional sources of unaligned accesses matching the
same pattern. Both nft-expr_quota-test and nft-expr_objref-test
generated unaligned accesses on DEC Alpha.
Bug: https://bugs.gentoo.org/666448
Signed-off-by: Matt Turner <mattst88@gmail.com>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
Diffstat (limited to 'src/chain.c')
| -rw-r--r-- | src/chain.c | 12 |
1 files changed, 6 insertions, 6 deletions
diff --git a/src/chain.c b/src/chain.c index 06252b6..01d62c8 100644 --- a/src/chain.c +++ b/src/chain.c @@ -190,22 +190,22 @@ int nftnl_chain_set_data(struct nftnl_chain *c, uint16_t attr, memcpy(&c->prio, data, sizeof(c->prio)); break; case NFTNL_CHAIN_POLICY: - c->policy = *((uint32_t *)data); + memcpy(&c->policy, data, sizeof(c->policy)); break; case NFTNL_CHAIN_USE: - c->use = *((uint32_t *)data); + memcpy(&c->use, data, sizeof(c->use)); break; case NFTNL_CHAIN_BYTES: - c->bytes = *((uint64_t *)data); + memcpy(&c->bytes, data, sizeof(c->bytes)); break; case NFTNL_CHAIN_PACKETS: - c->packets = *((uint64_t *)data); + memcpy(&c->packets, data, sizeof(c->packets)); break; case NFTNL_CHAIN_HANDLE: - c->handle = *((uint64_t *)data); + memcpy(&c->handle, data, sizeof(c->handle)); break; case NFTNL_CHAIN_FAMILY: - c->family = *((uint32_t *)data); + memcpy(&c->family, data, sizeof(c->family)); break; case NFTNL_CHAIN_TYPE: if (c->flags & (1 << NFTNL_CHAIN_TYPE)) |