diff options
author | Pablo Neira Ayuso <pablo@netfilter.org> | 2013-07-18 20:01:27 +0200 |
---|---|---|
committer | Pablo Neira Ayuso <pablo@netfilter.org> | 2013-07-18 20:08:25 +0200 |
commit | 6cdc49ffbe0a672c27f4fffe831563b12a8e2e61 (patch) | |
tree | 76e1b5318bfdd9627f8ab5138293cbe569c25da4 /src/expr/counter.c | |
parent | 5ecac519cd78043d0a5bfead1922a683d32db9d2 (diff) |
src: simplify getter logic
This patch refactors the getter code to simplify it. The default
cases have been removed so gcc will spot a warning if an attribute
is not handled appropriately.
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
Diffstat (limited to 'src/expr/counter.c')
-rw-r--r-- | src/expr/counter.c | 18 |
1 files changed, 4 insertions, 14 deletions
diff --git a/src/expr/counter.c b/src/expr/counter.c index 8521a22..8b2542d 100644 --- a/src/expr/counter.c +++ b/src/expr/counter.c @@ -55,21 +55,11 @@ nft_rule_expr_counter_get(const struct nft_rule_expr *e, uint16_t type, switch(type) { case NFT_EXPR_CTR_BYTES: - if (e->flags & (1 << NFT_EXPR_CTR_BYTES)) { - *data_len = sizeof(ctr->bytes); - return &ctr->bytes; - } else - return NULL; - break; + *data_len = sizeof(ctr->bytes); + return &ctr->bytes; case NFT_EXPR_CTR_PACKETS: - if (e->flags & (1 << NFT_EXPR_CTR_PACKETS)) { - *data_len = sizeof(ctr->pkts); - return &ctr->pkts; - } else - return NULL; - break; - default: - break; + *data_len = sizeof(ctr->pkts); + return &ctr->pkts; } return NULL; } |