path: root/src/expr/hash.c
diff options
authorPhil Sutter <>2021-03-09 11:26:47 +0100
committerPhil Sutter <>2021-03-15 12:23:20 +0100
commit960c8e6174374ee113b290c304365bf02ed346d6 (patch)
tree3c5b27821e29409822920e6113e1c3364ac5b4e9 /src/expr/hash.c
parent4f6e671b462180ba9af12bd30211811b5fca8cb1 (diff)
Drop pointless local variable in snprintf callbacks
A common idiom among snprintf callbacks was to copy the unsigned parameter 'size' (or 'len') into a signed variable for further use. Though since snprintf() itself casts it to unsigned and SNPRINTF_BUFFER_SIZE() does not allow it to become negative, this is not needed. Drop the local variable and rename the parameter accordingly. Signed-off-by: Phil Sutter <>
Diffstat (limited to 'src/expr/hash.c')
1 files changed, 2 insertions, 2 deletions
diff --git a/src/expr/hash.c b/src/expr/hash.c
index 86b5ca6..10b4a72 100644
--- a/src/expr/hash.c
+++ b/src/expr/hash.c
@@ -184,11 +184,11 @@ nftnl_expr_hash_parse(struct nftnl_expr *e, struct nlattr *attr)
static int
-nftnl_expr_hash_snprintf(char *buf, size_t size,
+nftnl_expr_hash_snprintf(char *buf, size_t remain,
uint32_t flags, const struct nftnl_expr *e)
struct nftnl_expr_hash *hash = nftnl_expr_data(e);
- int remain = size, offset = 0, ret;
+ int offset = 0, ret;
switch (hash->type) {