diff options
| author | Phil Sutter <phil@nwl.cc> | 2021-03-09 11:26:47 +0100 |
|---|---|---|
| committer | Phil Sutter <phil@nwl.cc> | 2021-03-15 12:23:20 +0100 |
| commit | 960c8e6174374ee113b290c304365bf02ed346d6 (patch) | |
| tree | 3c5b27821e29409822920e6113e1c3364ac5b4e9 /src/flowtable.c | |
| parent | 4f6e671b462180ba9af12bd30211811b5fca8cb1 (diff) | |
Drop pointless local variable in snprintf callbacks
A common idiom among snprintf callbacks was to copy the unsigned
parameter 'size' (or 'len') into a signed variable for further use.
Though since snprintf() itself casts it to unsigned and
SNPRINTF_BUFFER_SIZE() does not allow it to become negative, this is not
needed. Drop the local variable and rename the parameter accordingly.
Signed-off-by: Phil Sutter <phil@nwl.cc>
Diffstat (limited to 'src/flowtable.c')
| -rw-r--r-- | src/flowtable.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/src/flowtable.c b/src/flowtable.c index 658115d..d651066 100644 --- a/src/flowtable.c +++ b/src/flowtable.c @@ -591,10 +591,10 @@ int nftnl_flowtable_parse_file(struct nftnl_flowtable *c, return -1; } -static int nftnl_flowtable_snprintf_default(char *buf, size_t size, +static int nftnl_flowtable_snprintf_default(char *buf, size_t remain, const struct nftnl_flowtable *c) { - int ret, remain = size, offset = 0, i; + int ret, offset = 0, i; ret = snprintf(buf, remain, "flow table %s %s use %u size %u flags %x", c->table, c->name, c->use, c->size, c->ft_flags); @@ -623,12 +623,12 @@ static int nftnl_flowtable_snprintf_default(char *buf, size_t size, return offset; } -static int nftnl_flowtable_cmd_snprintf(char *buf, size_t size, +static int nftnl_flowtable_cmd_snprintf(char *buf, size_t remain, const struct nftnl_flowtable *c, uint32_t cmd, uint32_t type, uint32_t flags) { - int ret, remain = size, offset = 0; + int ret, offset = 0; switch (type) { case NFTNL_OUTPUT_DEFAULT: |