diff options
| author | Pablo Neira Ayuso <pablo@netfilter.org> | 2014-07-20 14:09:34 +0200 |
|---|---|---|
| committer | Pablo Neira Ayuso <pablo@netfilter.org> | 2014-07-20 15:04:47 +0200 |
| commit | 367cbfaae87c1f539c729b0653d920701beac3be (patch) | |
| tree | 232077cd854cc757784383b56abcde8383b006dd /src/set_elem.c | |
| parent | cac9b26874d60aa17c7cabe46d33e9114b24885d (diff) | |
src: stricter netlink attribute length validation
If the kernel sends us different data length for a given attribute,
stop further processing and indicate that an ABI breakage has ocurred.
This is an example of the (hypothetical) message that is shown in that
case:
nf_tables kernel ABI is broken, contact your vendor.
table.c:214 reason: Numerical result out of range
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
Diffstat (limited to 'src/set_elem.c')
| -rw-r--r-- | src/set_elem.c | 24 |
1 files changed, 8 insertions, 16 deletions
diff --git a/src/set_elem.c b/src/set_elem.c index 3b27317..197da73 100644 --- a/src/set_elem.c +++ b/src/set_elem.c @@ -232,17 +232,13 @@ static int nft_set_elem_parse_attr_cb(const struct nlattr *attr, void *data) switch(type) { case NFTA_SET_ELEM_FLAGS: - if (mnl_attr_validate(attr, MNL_TYPE_U32) < 0) { - perror("mnl_attr_validate"); - return MNL_CB_ERROR; - } + if (mnl_attr_validate(attr, MNL_TYPE_U32) < 0) + abi_breakage(); break; case NFTA_SET_ELEM_KEY: case NFTA_SET_ELEM_DATA: - if (mnl_attr_validate(attr, MNL_TYPE_NESTED) < 0) { - perror("mnl_attr_validate"); - return MNL_CB_ERROR; - } + if (mnl_attr_validate(attr, MNL_TYPE_NESTED) < 0) + abi_breakage(); break; } @@ -312,16 +308,12 @@ nft_set_elem_list_parse_attr_cb(const struct nlattr *attr, void *data) switch(type) { case NFTA_SET_ELEM_LIST_TABLE: case NFTA_SET_ELEM_LIST_SET: - if (mnl_attr_validate(attr, MNL_TYPE_STRING) < 0) { - perror("mnl_attr_validate"); - return MNL_CB_ERROR; - } + if (mnl_attr_validate(attr, MNL_TYPE_STRING) < 0) + abi_breakage(); break; case NFTA_SET_ELEM_LIST_ELEMENTS: - if (mnl_attr_validate(attr, MNL_TYPE_NESTED) < 0) { - perror("mnl_attr_validate"); - return MNL_CB_ERROR; - } + if (mnl_attr_validate(attr, MNL_TYPE_NESTED) < 0) + abi_breakage(); break; } |