summaryrefslogtreecommitdiffstats
path: root/src/set_elem.c
diff options
context:
space:
mode:
authorCarlos Falgueras García <carlosfg@riseup.net>2015-08-05 12:23:34 +0200
committerPablo Neira Ayuso <pablo@netfilter.org>2015-08-18 01:52:01 +0200
commit6e188637782c6c62c7bcade808e59d17639d677d (patch)
tree658c9400a8f7beb07b00b445b9a7d0eba6bcea89 /src/set_elem.c
parent0edeb667a2cfdd36d8c89de88e1a446595ce95d8 (diff)
src: fix memory leaks at nft_[object]_nlmsg_parse
Free object attributes before overwrite it. Fix 'nlmsg_parse' methods of following objects: 'table', 'chain', 'rule', 'set' and 'set_element'. Signed-off-by: Carlos Falgueras García <carlosfg@riseup.net> Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
Diffstat (limited to 'src/set_elem.c')
-rw-r--r--src/set_elem.c2
1 files changed, 2 insertions, 0 deletions
diff --git a/src/set_elem.c b/src/set_elem.c
index 3a799dc..643dd76 100644
--- a/src/set_elem.c
+++ b/src/set_elem.c
@@ -462,11 +462,13 @@ int nft_set_elems_nlmsg_parse(const struct nlmsghdr *nlh, struct nft_set *s)
return -1;
if (tb[NFTA_SET_ELEM_LIST_TABLE]) {
+ xfree(s->table);
s->table =
strdup(mnl_attr_get_str(tb[NFTA_SET_ELEM_LIST_TABLE]));
s->flags |= (1 << NFT_SET_ATTR_TABLE);
}
if (tb[NFTA_SET_ELEM_LIST_SET]) {
+ xfree(s->name);
s->name =
strdup(mnl_attr_get_str(tb[NFTA_SET_ELEM_LIST_SET]));
s->flags |= (1 << NFT_SET_ATTR_NAME);