summaryrefslogtreecommitdiffstats
path: root/src
diff options
context:
space:
mode:
authorPablo Neira Ayuso <pablo@netfilter.org>2013-07-25 20:44:13 +0200
committerPablo Neira Ayuso <pablo@netfilter.org>2013-07-25 20:50:52 +0200
commit1c86a5f0f9df07b66691115ba4b0a9ee0f978dd6 (patch)
treeef3e4ccae6159e89146a9f93fe919733c87952cf /src
parent69efde1a7f4a9640506005bd4d51b3461d3c7d53 (diff)
expr: cmp: cmpdata is mandatory node
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
Diffstat (limited to 'src')
-rw-r--r--src/expr/cmp.c12
1 files changed, 4 insertions, 8 deletions
diff --git a/src/expr/cmp.c b/src/expr/cmp.c
index cbc08ec..0a7c9e2 100644
--- a/src/expr/cmp.c
+++ b/src/expr/cmp.c
@@ -190,15 +190,11 @@ static int nft_rule_expr_cmp_xml_parse(struct nft_rule_expr *e, mxml_node_t *tre
e->flags |= (1 << NFT_EXPR_CMP_OP);
}
- /* Get and set <cmpdata>. Is not mandatory */
- node = mxmlFindElement(tree, tree, "cmpdata", NULL, NULL, MXML_DESCEND);
- if (node != NULL) {
- if (nft_mxml_data_reg_parse(tree, "cmpdata",
- &cmp->data) != DATA_VALUE) {
- return -1;
- }
- e->flags |= (1 << NFT_EXPR_CMP_DATA);
+ if (nft_mxml_data_reg_parse(tree, "cmpdata",
+ &cmp->data) != DATA_VALUE) {
+ return -1;
}
+ e->flags |= (1 << NFT_EXPR_CMP_DATA);
return 0;
#else