From dc240913458d591f59b52b3899d3fc3c5d6ec6ce Mon Sep 17 00:00:00 2001 From: Matt Turner Date: Wed, 17 Oct 2018 12:32:54 -0700 Subject: src: Use memcpy() to handle potentially unaligned data Rolf Eike Beer reported that nft-expr_quota-test fails with a SIGBUS on SPARC due to unaligned accesses. This patch resolves that and fixes additional sources of unaligned accesses matching the same pattern. Both nft-expr_quota-test and nft-expr_objref-test generated unaligned accesses on DEC Alpha. Bug: https://bugs.gentoo.org/666448 Signed-off-by: Matt Turner Signed-off-by: Pablo Neira Ayuso --- src/expr/byteorder.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) (limited to 'src/expr/byteorder.c') diff --git a/src/expr/byteorder.c b/src/expr/byteorder.c index 4cddd4a..35c1450 100644 --- a/src/expr/byteorder.c +++ b/src/expr/byteorder.c @@ -37,19 +37,19 @@ nftnl_expr_byteorder_set(struct nftnl_expr *e, uint16_t type, switch(type) { case NFTNL_EXPR_BYTEORDER_SREG: - byteorder->sreg = *((uint32_t *)data); + memcpy(&byteorder->sreg, data, sizeof(byteorder->sreg)); break; case NFTNL_EXPR_BYTEORDER_DREG: - byteorder->dreg = *((uint32_t *)data); + memcpy(&byteorder->dreg, data, sizeof(byteorder->dreg)); break; case NFTNL_EXPR_BYTEORDER_OP: - byteorder->op = *((uint32_t *)data); + memcpy(&byteorder->op, data, sizeof(byteorder->op)); break; case NFTNL_EXPR_BYTEORDER_LEN: - byteorder->len = *((unsigned int *)data); + memcpy(&byteorder->len, data, sizeof(byteorder->len)); break; case NFTNL_EXPR_BYTEORDER_SIZE: - byteorder->size = *((unsigned int *)data); + memcpy(&byteorder->size, data, sizeof(byteorder->size)); break; default: return -1; -- cgit v1.2.3