From 5819e46b47c331be01c2f417085c516f3f0aded3 Mon Sep 17 00:00:00 2001 From: Phil Sutter Date: Tue, 9 Mar 2021 11:14:29 +0100 Subject: expr: Fix snprintf buffer length updates Subsequent calls to snprintf() sometimes reuse 'len' variable although they should refer to the updated value in 'remain' instead. Fixes: 676ea569bbe5a ("src: Change parameters of SNPRINTF_BUFFER_SIZE macro.") Signed-off-by: Phil Sutter --- src/expr/ct.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'src/expr/ct.c') diff --git a/src/expr/ct.c b/src/expr/ct.c index 124de9d..1a21c95 100644 --- a/src/expr/ct.c +++ b/src/expr/ct.c @@ -230,7 +230,7 @@ nftnl_expr_ct_snprintf_default(char *buf, size_t size, struct nftnl_expr_ct *ct = nftnl_expr_data(e); if (e->flags & (1 << NFTNL_EXPR_CT_SREG)) { - ret = snprintf(buf, size, "set %s with reg %u ", + ret = snprintf(buf, remain, "set %s with reg %u ", ctkey2str(ct->key), ct->sreg); SNPRINTF_BUFFER_SIZE(ret, remain, offset); } -- cgit v1.2.3