From 960c8e6174374ee113b290c304365bf02ed346d6 Mon Sep 17 00:00:00 2001 From: Phil Sutter Date: Tue, 9 Mar 2021 11:26:47 +0100 Subject: Drop pointless local variable in snprintf callbacks A common idiom among snprintf callbacks was to copy the unsigned parameter 'size' (or 'len') into a signed variable for further use. Though since snprintf() itself casts it to unsigned and SNPRINTF_BUFFER_SIZE() does not allow it to become negative, this is not needed. Drop the local variable and rename the parameter accordingly. Signed-off-by: Phil Sutter --- src/expr/dup.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'src/expr/dup.c') diff --git a/src/expr/dup.c b/src/expr/dup.c index 3eb560a..f041b55 100644 --- a/src/expr/dup.c +++ b/src/expr/dup.c @@ -111,11 +111,11 @@ static int nftnl_expr_dup_parse(struct nftnl_expr *e, struct nlattr *attr) return ret; } -static int nftnl_expr_dup_snprintf(char *buf, size_t len, +static int nftnl_expr_dup_snprintf(char *buf, size_t remain, uint32_t flags, const struct nftnl_expr *e) { - int remain = len, offset = 0, ret; struct nftnl_expr_dup *dup = nftnl_expr_data(e); + int offset = 0, ret; if (e->flags & (1 << NFTNL_EXPR_DUP_SREG_ADDR)) { ret = snprintf(buf + offset, remain, "sreg_addr %u ", dup->sreg_addr); -- cgit v1.2.3