From 3cf788a720b30530ca0fe86d40e2e86139e7d48c Mon Sep 17 00:00:00 2001 From: Pablo Neira Ayuso Date: Thu, 14 Nov 2013 15:19:03 +0100 Subject: expr: fix leak in target and match expressions Release internal data area for match and target expressions. ==30104== 68 bytes in 1 blocks are definitely lost in loss record 1 of 1 ==30104== at 0x4C2B514: calloc (vg_replace_malloc.c:593) ==30104== by 0x400C2F: main (nft-expr_match-test.c:65) Reported-by: Ana Rey Botello Signed-off-by: Pablo Neira Ayuso --- src/expr/target.c | 8 ++++++++ 1 file changed, 8 insertions(+) (limited to 'src/expr/target.c') diff --git a/src/expr/target.c b/src/expr/target.c index 7994bcd..20bf2af 100644 --- a/src/expr/target.c +++ b/src/expr/target.c @@ -260,10 +260,18 @@ nft_rule_expr_target_snprintf(char *buf, size_t len, uint32_t type, return -1; } +static void nft_rule_expr_target_free(struct nft_rule_expr *e) +{ + struct nft_expr_target *target = nft_expr_data(e); + + xfree(target->data); +} + struct expr_ops expr_ops_target = { .name = "target", .alloc_len = sizeof(struct nft_expr_target), .max_attr = NFTA_TARGET_MAX, + .free = nft_rule_expr_target_free, .set = nft_rule_expr_target_set, .get = nft_rule_expr_target_get, .parse = nft_rule_expr_target_parse, -- cgit v1.2.3