From 54fc1f15cc8a14c333a216e93a8e2a3d1cbca67e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Carlos=20Falgueras=20Garc=C3=ADa?= Date: Wed, 24 Aug 2016 14:22:16 +0200 Subject: expr: data_reg: Fix DATA_CHAIN comparison MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Split DATA_VERDICT and DATA_CHAIN comparison. A verdict can have a NULL chain (accept, drop, etc) so segfault will happen when strcmp is called. Signed-off-by: Carlos Falgueras García Signed-off-by: Pablo Neira Ayuso --- src/expr/data_reg.c | 1 + 1 file changed, 1 insertion(+) (limited to 'src/expr') diff --git a/src/expr/data_reg.c b/src/expr/data_reg.c index a954e95..395e9f6 100644 --- a/src/expr/data_reg.c +++ b/src/expr/data_reg.c @@ -387,6 +387,7 @@ bool nftnl_data_reg_cmp(const union nftnl_data_reg *r1, return r1->len == r2->len && !memcmp(r1->val, r2->val, r1->len); case DATA_VERDICT: + return r1->verdict == r2->verdict; case DATA_CHAIN: return r1->verdict == r2->verdict && !strcmp(r1->chain, r2->chain); -- cgit v1.2.3