From 6e188637782c6c62c7bcade808e59d17639d677d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Carlos=20Falgueras=20Garc=C3=ADa?= Date: Wed, 5 Aug 2015 12:23:34 +0200 Subject: src: fix memory leaks at nft_[object]_nlmsg_parse MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Free object attributes before overwrite it. Fix 'nlmsg_parse' methods of following objects: 'table', 'chain', 'rule', 'set' and 'set_element'. Signed-off-by: Carlos Falgueras GarcĂ­a Signed-off-by: Pablo Neira Ayuso --- src/set_elem.c | 2 ++ 1 file changed, 2 insertions(+) (limited to 'src/set_elem.c') diff --git a/src/set_elem.c b/src/set_elem.c index 3a799dc..643dd76 100644 --- a/src/set_elem.c +++ b/src/set_elem.c @@ -462,11 +462,13 @@ int nft_set_elems_nlmsg_parse(const struct nlmsghdr *nlh, struct nft_set *s) return -1; if (tb[NFTA_SET_ELEM_LIST_TABLE]) { + xfree(s->table); s->table = strdup(mnl_attr_get_str(tb[NFTA_SET_ELEM_LIST_TABLE])); s->flags |= (1 << NFT_SET_ATTR_TABLE); } if (tb[NFTA_SET_ELEM_LIST_SET]) { + xfree(s->name); s->name = strdup(mnl_attr_get_str(tb[NFTA_SET_ELEM_LIST_SET])); s->flags |= (1 << NFT_SET_ATTR_NAME); -- cgit v1.2.3