From cc9573dfa25585a415f6c12950758ce32f337294 Mon Sep 17 00:00:00 2001 From: Pablo Neira Ayuso Date: Sun, 21 Jul 2013 15:26:02 +0200 Subject: src: remove default case from nft_*_attr_unset This patch removes the default case in nft_*_attr_unset, thus, the compiler will spot a warning if we add a new attribute in the future and you forget to handle it. Signed-off-by: Pablo Neira Ayuso --- src/table.c | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) (limited to 'src/table.c') diff --git a/src/table.c b/src/table.c index b2ebaa3..e9e6d59 100644 --- a/src/table.c +++ b/src/table.c @@ -57,20 +57,19 @@ EXPORT_SYMBOL(nft_table_attr_is_set); void nft_table_attr_unset(struct nft_table *t, uint16_t attr) { + if (!(t->flags & (1 << attr))) + return; + switch (attr) { case NFT_TABLE_ATTR_NAME: - if (t->flags & (1 << NFT_TABLE_ATTR_NAME)) { - if (t->name) { - free(t->name); - t->name = NULL; - } + if (t->name) { + free(t->name); + t->name = NULL; } break; case NFT_TABLE_ATTR_FLAGS: case NFT_TABLE_ATTR_FAMILY: break; - default: - return; } t->flags &= ~(1 << attr); } -- cgit v1.2.3