From dccedc04051e246d6a553c35c280f2bf9e2e8fd1 Mon Sep 17 00:00:00 2001 From: Ana Rey Date: Mon, 23 Jun 2014 11:38:18 +0200 Subject: expr: target: Use nft_rule_expr_set_* in the xml parsing code Code refactoring to use nft_rule_expr_set_* in parse functions Signed-off-by: Ana Rey Signed-off-by: Pablo Neira Ayuso --- src/expr/target.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) (limited to 'src') diff --git a/src/expr/target.c b/src/expr/target.c index 5245ff7..623d22c 100644 --- a/src/expr/target.c +++ b/src/expr/target.c @@ -195,7 +195,6 @@ nft_rule_expr_target_xml_parse(struct nft_rule_expr *e, mxml_node_t *tree, struct nft_parse_err *err) { #ifdef XML_PARSING - struct nft_expr_target *tg = nft_expr_data(e); const char *name; name = nft_mxml_str_parse(tree, "name", MXML_DESCEND_FIRST, @@ -203,9 +202,7 @@ nft_rule_expr_target_xml_parse(struct nft_rule_expr *e, mxml_node_t *tree, if (name == NULL) return -1; - strncpy(tg->name, name, XT_EXTENSION_MAXNAMELEN); - tg->name[XT_EXTENSION_MAXNAMELEN-1] = '\0'; - e->flags |= (1 << NFT_EXPR_TG_NAME); + nft_rule_expr_set_str(e, NFT_EXPR_TG_NAME, name); /* tg->info is ignored until other solution is reached */ -- cgit v1.2.3