summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorHarsha Sharma <harshasharmaiitr@gmail.com>2017-11-24 00:25:14 +0530
committerPablo Neira Ayuso <pablo@netfilter.org>2017-11-27 23:54:13 +0100
commit39d453a15dd3e1a349edc5618861aad63991419a (patch)
tree0c8f74bb22dbd7299546ee8e78a7229bbba1bb03
parentfc6c7287f7ed7f005a226856ed93bcd1475f208c (diff)
evaluate: print error for null string
Print error "Empty string is not allowed", eg. # nft add rule filter input meta iifname '""' add rule filter input meta iifname "" ^^ Error: Empty String is not allowed Signed-off-by: Harsha Sharma <harshasharmaiitr@gmail.com> Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
-rw-r--r--src/evaluate.c5
1 files changed, 4 insertions, 1 deletions
diff --git a/src/evaluate.c b/src/evaluate.c
index b0ce9f63..758e7bbe 100644
--- a/src/evaluate.c
+++ b/src/evaluate.c
@@ -235,7 +235,10 @@ static int expr_evaluate_string(struct eval_ctx *ctx, struct expr **exprp)
memset(data + len, 0, data_len - len);
mpz_export_data(data, expr->value, BYTEORDER_HOST_ENDIAN, len);
- assert(strlen(data) > 0);
+ if (strlen(data) == 0)
+ return expr_error(ctx->msgs, expr,
+ "Empty string is not allowed");
+
datalen = strlen(data) - 1;
if (data[datalen] != '*') {
/* We need to reallocate the constant expression with the right