summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorPhil Sutter <phil@nwl.cc>2018-05-05 14:44:26 +0200
committerPablo Neira Ayuso <pablo@netfilter.org>2018-05-06 22:56:23 +0200
commitcb5f6e846667f69a508559790a3ea84820f86842 (patch)
tree6fb9987319ab576711ca3116dc9da70f8affa1c2
parenta84f9329d2f6c75b07f5d5030271686010b4b41e (diff)
proto: Fix wrong token in proto_icmp6
'token' value of ICMP6HDR_MTU field must be 'mtu', not 'packet-too-big'. This went unnoticed because rule delinearization for icmp/icmpv6 payload expressions is problematic anyway in that different fields point to the same offset and therefore are indistinguishable. In this case, an expression like e.g. 'icmpv6 mtu 1500' will be printed later as 'icmpv6 parameter-problem 1500'. Signed-off-by: Phil Sutter <phil@nwl.cc> Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
-rw-r--r--src/proto.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/src/proto.c b/src/proto.c
index 8cf29d20..ed011efa 100644
--- a/src/proto.c
+++ b/src/proto.c
@@ -689,7 +689,7 @@ const struct proto_desc proto_icmp6 = {
[ICMP6HDR_CODE] = ICMP6HDR_FIELD("code", icmp6_code),
[ICMP6HDR_CHECKSUM] = ICMP6HDR_FIELD("checksum", icmp6_cksum),
[ICMP6HDR_PPTR] = ICMP6HDR_FIELD("parameter-problem", icmp6_pptr),
- [ICMP6HDR_MTU] = ICMP6HDR_FIELD("packet-too-big", icmp6_mtu),
+ [ICMP6HDR_MTU] = ICMP6HDR_FIELD("mtu", icmp6_mtu),
[ICMP6HDR_ID] = ICMP6HDR_FIELD("id", icmp6_id),
[ICMP6HDR_SEQ] = ICMP6HDR_FIELD("sequence", icmp6_seq),
[ICMP6HDR_MAXDELAY] = ICMP6HDR_FIELD("max-delay", icmp6_maxdelay),