diff options
author | Phil Sutter <phil@nwl.cc> | 2017-09-21 15:10:39 +0200 |
---|---|---|
committer | Pablo Neira Ayuso <pablo@netfilter.org> | 2017-09-27 14:11:58 +0200 |
commit | b8387bb0b0a2e53a5f74814625b374b3b4b0c932 (patch) | |
tree | 277c91276470940ec1ea4222d7ccb413c56a6d8a | |
parent | d423f0e99a3630a07f622a934f1041d55e8115c0 (diff) |
main: Fix for return of uninitialized variable in nft_run_cmd_from_filename()
If scanner_read_file() failed, the function would return an
uninitialized value.
Fixes: 3db28321b64a6 ("src: add nft_run_cmd_*() functions")
Signed-off-by: Phil Sutter <phil@nwl.cc>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
-rw-r--r-- | src/main.c | 4 |
1 files changed, 3 insertions, 1 deletions
@@ -351,8 +351,10 @@ static int nft_run_cmd_from_filename(struct nft_ctx *nft, const char *filename) parser_init(nft->nf_sock, &nft->cache, &state, &msgs, nft->debug_mask); scanner = scanner_init(&state); - if (scanner_read_file(scanner, filename, &internal_location) < 0) + if (scanner_read_file(scanner, filename, &internal_location) < 0) { + rc = NFT_EXIT_FAILURE; goto err; + } if (nft_run(nft, nft->nf_sock, scanner, &state, &msgs) != 0) rc = NFT_EXIT_FAILURE; |